]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
spi: stm32: fix stm32_spi_prepare_mbr() that halves spi clk for every run
authorSean Nyekjaer <sean@geanix.com>
Thu, 3 Nov 2022 08:00:42 +0000 (09:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Dec 2022 16:39:58 +0000 (17:39 +0100)
commit361a1650989855ccda14f63c1b2e0b0f1f5a7ded
tree6c861cb8e6d2b4c1cd5b15b5affb7faefe796fbc
parent2c1ca23555ed63ddca59a06214a96ab2bd417c48
spi: stm32: fix stm32_spi_prepare_mbr() that halves spi clk for every run

[ Upstream commit 62aa1a344b0904549f6de7af958e8a1136fd5228 ]

When this driver is used with a driver that uses preallocated spi_transfer
structs. The speed_hz is halved by every run. This results in:

spi_stm32 44004000.spi: SPI transfer setup failed
ads7846 spi0.0: SPI transfer failed: -22

Example when running with DIV_ROUND_UP():
- First run; speed_hz = 1000000, spi->clk_rate 125000000
  div 125 -> mbrdiv = 7, cur_speed = 976562
- Second run; speed_hz = 976562
  div 128,00007 (roundup to 129) -> mbrdiv = 8, cur_speed = 488281
- Third run; speed_hz = 488281
  div 256,000131072067109 (roundup to 257) and then -EINVAL is returned.

Use DIV_ROUND_CLOSEST to allow to round down and allow us to keep the
set speed.

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Link: https://lore.kernel.org/r/20221103080043.3033414-1-sean@geanix.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-stm32.c