]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: v4l2-mem2mem: Document that v4l2_m2m_get_vq() never returns NULL
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Wed, 15 Oct 2025 07:53:24 +0000 (10:53 +0300)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:14 +0000 (11:31 +0200)
commit3662b54c16924b03197ec80f9764aabdf2c90231
treed692f1fc8acedf836453df5b5c264a5a8b89d387
parent082b86919b7a94de01d849021b4da820a6cb89dc
media: v4l2-mem2mem: Document that v4l2_m2m_get_vq() never returns NULL

The v4l2_m2m_get_vq() never returns a NULL pointer, as the internal
get_queue_ctx() helper always returns a non-NULL pointer. Many drivers
check the return value against NULL, due to a combination of old code
and cargo-cult programming. Even v4l2-mem2mem.c contains unneeded NULL
checks.

Clarify the API by documenting explicitly that a NULL check is not
needed, and simplify the code by removing the unneeded NULL checks from
v4l2-mem2mem.c.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/v4l2-core/v4l2-mem2mem.c
include/media/v4l2-mem2mem.h