]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
lib82596: Fix IRQ check in sni_82596_probe
authorMiaoqian Lin <linmq006@gmail.com>
Fri, 14 Jan 2022 06:57:24 +0000 (06:57 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 07:46:21 +0000 (08:46 +0100)
commit366ad1349169b727dff719bf5e9e71a11502d747
treed2e2a2f8f5280c4c9e7da667e35958a1e1662552
parent9022d9f1b542954e85356f6bd2b29a3463550b8f
lib82596: Fix IRQ check in sni_82596_probe

commit 99218cbf81bf21355a3de61cd46a706d36e900e6 upstream.

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: 115978859272 ("i825xx: Move the Intel 82586/82593/82596 based drivers")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/i825xx/sni_82596.c