]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nvmem: u-boot-env: improve coding style
authorRafał Miłecki <rafal@milecki.pl>
Thu, 21 Dec 2023 17:34:20 +0000 (18:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Sep 2024 17:24:04 +0000 (19:24 +0200)
commit368fa77b7945bdbdf0e3bb26b5abcae4fba25a20
tree4d354d734d62e987a39f9000b372c45cc3a542f5
parent2eea394c31cbc3d853a26ef2ddb8f5bd24d4d002
nvmem: u-boot-env: improve coding style

[ Upstream commit 6bafe07c930676d6430be471310958070816a595 ]

1. Prefer kzalloc() over kcalloc()
   See memory-allocation.rst which says: "to be on the safe side it's
   best to use routines that set memory to zero, like kzalloc()"
2. Drop dev_err() for u_boot_env_add_cells() fail
   It can fail only on -ENOMEM. We don't want to print error then.
3. Add extra "crc32_addr" variable
   It makes code reading header's crc32 easier to understand / review.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20231221173421.13737-5-zajec5@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stable-dep-of: 8679e8b4a1eb ("nvmem: u-boot-env: error if NVMEM device is too small")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvmem/u-boot-env.c