]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix waiting in RegisterSyncRequest().
authorThomas Munro <tmunro@postgresql.org>
Wed, 16 Mar 2022 02:38:13 +0000 (15:38 +1300)
committerThomas Munro <tmunro@postgresql.org>
Wed, 16 Mar 2022 02:38:13 +0000 (15:38 +1300)
commit368ffdeee422e8df57330a290f32b986291c2584
treeca63ebc659ee6b1ad9852fc56561e224dc8a8dc0
parentaf8a8eb54245b2f24bbe1b93811fffbb71cca235
Fix waiting in RegisterSyncRequest().

If we run out of space in the checkpointer sync request queue (which is
hopefully rare on real systems, but common with very small buffer pool),
we wait for it to drain.  While waiting, we should report that as a wait
event so that users know what is going on, and also handle postmaster
death, since otherwise the loop might never terminate if the
checkpointer has exited.

Back-patch to 12.  Although the problem exists in earlier releases too,
the code is structured differently before 12 so I haven't gone any
further for now, in the absence of field complaints.

Reported-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220226213942.nb7uvb2pamyu26dj%40alap3.anarazel.de
doc/src/sgml/monitoring.sgml
src/backend/postmaster/pgstat.c
src/backend/storage/sync/sync.c
src/include/pgstat.h