]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
GH-95704: Don't suppress errors from tasks when TG is cancelled (GH-95761)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 17 Aug 2022 17:04:59 +0000 (10:04 -0700)
committerGitHub <noreply@github.com>
Wed, 17 Aug 2022 17:04:59 +0000 (10:04 -0700)
commit36c114ab11d478c9ede246035606c12fc080e6ff
tree1ea0cda50707031ab99942c2adfd59242d0a1e0d
parent2bb363cfcd7563fdd29ac93563f95b8a5205b008
GH-95704: Don't suppress errors from tasks when TG is cancelled (GH-95761)

When a task catches CancelledError and raises some other error,
the other error should not silently be suppressed.

Any scenario where a task crashes in cleanup upon cancellation
will now result in an ExceptionGroup wrapping the crash(es)
instead of propagating CancelledError and ignoring the side errors.

NOTE: This represents a change in behavior (hence the need to
change several tests).  But it is only an edge case.

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
(cherry picked from commit f51f54f39d384da63be622bcdc9cf4cfb43bad3d)

Co-authored-by: Guido van Rossum <guido@python.org>
Lib/asyncio/taskgroups.py
Lib/test/test_asyncio/test_taskgroups.py
Misc/NEWS.d/next/Library/2022-08-08-01-42-11.gh-issue-95704.MOPFfX.rst [new file with mode: 0644]