]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/amd/pm/powerplay/hwmgr/smu_helper: fix order of mask and value
authorFedor Pchelkin <pchelkin@ispras.ru>
Mon, 30 Jun 2025 20:26:17 +0000 (23:26 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Aug 2025 10:04:57 +0000 (12:04 +0200)
commit36cd0dcd0eb12674234d87a1fcb1a463bc3b44d0
treefd9c46f50e808765130291f7a86e7aab50c2e7ad
parent803538f998013caf56f158ea5de8466fa0bfed93
drm/amd/pm/powerplay/hwmgr/smu_helper: fix order of mask and value

[ Upstream commit a54e4639c4ef37a0241bac7d2a77f2e6ffb57099 ]

There is a small typo in phm_wait_on_indirect_register().

Swap mask and value arguments provided to phm_wait_on_register() so that
they satisfy the function signature and actual usage scheme.

Found by Linux Verification Center (linuxtesting.org) with Svace static
analysis tool.

In practice this doesn't fix any issues because the only place this
function is used uses the same value for the value and mask.

Fixes: 3bace3591493 ("drm/amd/powerplay: add hardware manager sub-component")
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c