]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
i2c: amd-mp2: fix reference leak in MP2 PCI device
authorMa Ke <make24@iscas.ac.cn>
Wed, 22 Oct 2025 09:54:02 +0000 (17:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:30 +0000 (10:14 +0100)
commit36f3cc056dd8596ce2e7c146c78414eda0e468a8
treec3a07c7c6bda6dd79905be3598c1ee36275e6910
parent85d7acd4138105f6163f4f29cb2c0df9c560b99e
i2c: amd-mp2: fix reference leak in MP2 PCI device

commit a6ee6aac66fb394b7f6e6187c73bdcd873f2d139 upstream.

In i2c_amd_probe(), amd_mp2_find_device() utilizes
driver_find_next_device() which internally calls driver_find_device()
to locate the matching device. driver_find_device() increments the
reference count of the found device by calling get_device(), but
amd_mp2_find_device() fails to call put_device() to decrement the
reference count before returning. This results in a reference count
leak of the PCI device each time i2c_amd_probe() is executed, which
may prevent the device from being properly released and cause a memory
leak.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 529766e0a011 ("i2c: Add drivers for the AMD PCIe MP2 I2C controller")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20251022095402.8846-1-make24@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i2c/busses/i2c-amd-mp2-pci.c