]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commit
oeqa/qemurunner: do not use Popen.poll() when terminating runqemu with a signal
authorAlexander Kanavin <alex.kanavin@gmail.com>
Mon, 30 Jan 2023 22:11:25 +0000 (23:11 +0100)
committerSteve Sakoman <steve@sakoman.com>
Mon, 20 Feb 2023 15:51:44 +0000 (05:51 -1000)
commit3793662bcfdab230d7b98bde2bc6757949b0aca0
treeb45cfbd885137be325b92f6ee744553a43d846e4
parent85cb9212a85e32715209705a29c6928b368d87c7
oeqa/qemurunner: do not use Popen.poll() when terminating runqemu with a signal

This does not actually guarantee that the child runqemu process has completely exited:
poll() may return prematurely while the SIGTERM handler in runqemu is still running.
This thwarts the rest of the processing, and may terminate the handler before
it completes.

Use Popen.communicate() instead: this is what python documentation recommends as well:
https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit cd3e55606c427287f37585c5d7cde936471e52f4)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/lib/oeqa/utils/qemurunner.py