]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
sunrpc: Fix error handling in rpc_sysfs_xprt_switch_add_xprt_store()
authorHongling Zeng <zenghongling@kylinos.cn>
Wed, 13 May 2026 09:28:59 +0000 (17:28 +0800)
committerAnna Schumaker <anna.schumaker@hammerspace.com>
Mon, 8 Jun 2026 14:21:55 +0000 (10:21 -0400)
commit37957478be021b92981aa4c99b69f308d3b784d0
treeb7b818c7257a8a1041ff9adfecbc4097006be791
parentbd5e6b056bd0900d8efde90da7a5877dc50842c7
sunrpc: Fix error handling in rpc_sysfs_xprt_switch_add_xprt_store()

xprt_create_transport() never returns NULL, only valid pointers or
error pointers. Using IS_ERR_OR_NULL() is incorrect, and PTR_ERR(NULL)
would return 0, which indicates EOF in a sysfs store function.

Fix this by using IS_ERR() instead of IS_ERR_OR_NULL().

Fixes: df210d9b0951 ("sunrpc: Add a sysfs file for adding a new xprt")
Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
Signed-off-by: Anna Schumaker <anna.schumaker@hammerspace.com>
net/sunrpc/sysfs.c