]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: usbtmc: Fix erroneous generic_read ioctl return
authorDave Penkler <dpenkler@gmail.com>
Fri, 2 May 2025 07:09:41 +0000 (09:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 May 2025 06:24:09 +0000 (08:24 +0200)
commit37a55b692d42e190b7c59d471044962e25a82694
tree66fcb29ab85e5d24f2baa0678bda45c0ba6083af
parent1991ed796d9a3f5aca1108c6d054a2502b3b70f7
usb: usbtmc: Fix erroneous generic_read ioctl return

commit 4e77d3ec7c7c0d9535ccf1138827cb9bb5480b9b upstream.

wait_event_interruptible_timeout returns a long
The return value was being assigned to an int causing an integer overflow
when the remaining jiffies > INT_MAX which resulted in random error
returns.

Use a long return value, converting to the int ioctl return only on error.

Fixes: bb99794a4792 ("usb: usbtmc: Add ioctl for vendor specific read")
Cc: stable@vger.kernel.org
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250502070941.31819-4-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/usbtmc.c