]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
taint/module: remove unnecessary taint_flag.module field
authorPetr Pavlu <petr.pavlu@suse.com>
Wed, 22 Oct 2025 08:28:04 +0000 (10:28 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 12 Nov 2025 18:00:15 +0000 (10:00 -0800)
commit37ade54f386c829597f74b54bad335c12bd2a698
tree3298f30059cca8561d4c27446866e7adf7830add
parented4bbe7e8fa186b24c61aa22a32885d5de0fe1a4
taint/module: remove unnecessary taint_flag.module field

The TAINT_RANDSTRUCT and TAINT_FWCTL flags are mistakenly set in the
taint_flags table as per-module flags.  While this can be trivially
corrected, the issue can be avoided altogether by removing the
taint_flag.module field.

This is possible because, since commit 7fd8329ba502 ("taint/module: Clean
up global and module taint flags handling") in 2016, the handling of
module taint flags has been fully generic.  Specifically,
module_flags_taint() can print all flags, and the required output buffer
size is properly defined in terms of TAINT_FLAGS_COUNT.  The actual
per-module flags are always those added to module.taints by calls to
add_taint_module().

Link: https://lkml.kernel.org/r/20251022082938.26670-1-petr.pavlu@suse.com
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Acked-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Aaron Tomlin <atomlin@atomlin.com>
Cc: Luis Chamberalin <mcgrof@kernel.org>
Cc: Petr Pavlu <petr.pavlu@suse.com>
Cc: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/panic.h
kernel/module/main.c
kernel/panic.c