]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gpio: nomadik: fix offset bug in nmk_pmx_set()
authorThéo Lebrun <theo.lebrun@bootlin.com>
Wed, 28 Feb 2024 11:28:03 +0000 (12:28 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:54 +0000 (18:19 -0400)
commit37e0f758e0573fefab300cfd602a4a0a1709678c
tree4633a443738eae9c9e435ce73d0ccb0bd1bd5027
parent310ae9eb3d2a13345f2590e7581fd45d97323a02
gpio: nomadik: fix offset bug in nmk_pmx_set()

[ Upstream commit 53cf6b72e074864b94ade97dcb6f30b5ac1a82dc ]

Previously, the statement looked like:

    slpm[x] &= ~BIT(g->grp.pins[i]);

Where:
 - slpm is a unsigned int pointer;
 - g->grp.pins[i] is a pin number. It can grow to more than 32.

The expected shift amount is a pin bank offset.

This bug does not occur on every group or pin: the altsetting must be
NMK_GPIO_ALT_C and the pin must be 32 or above. It might have occured.
For example, in pinctrl-nomadik-db8500.c, pin group i2c3_c_2 has the
right altsetting and pins 229 and 230.

Fixes: dbfe8ca259e1 ("pinctrl/nomadik: implement pin multiplexing")
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
Link: https://lore.kernel.org/r/20240228-mbly-gpio-v2-5-3ba757474006@bootlin.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/nomadik/pinctrl-nomadik.c