]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
objtool/x86: add missing embedded_insn check
authorJohn Sperbeck <jsperbeck@google.com>
Sat, 28 Oct 2023 18:41:31 +0000 (18:41 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Nov 2023 16:26:43 +0000 (17:26 +0100)
commit37ffa428d58c87016c735c4ca3091873896ba52d
tree2570265f50da4fb9f186a72b406eca73d2887e21
parentf031e15d0bb8fb782a54f883545145a367ff5f5f
objtool/x86: add missing embedded_insn check

When dbf460087755 ("objtool/x86: Fixup frame-pointer vs rethunk")
was backported to some stable branches, the check for dest->embedded_insn
in is_special_call() was missed.  The result is that the warning it
was intended to suppress still appears.  For example on 6.1 (on kernels
before 6.1, the '-s' argument would instead be 'check'):

$ tools/objtool/objtool -s arch/x86/lib/retpoline.o
arch/x86/lib/retpoline.o: warning: objtool: srso_untrain_ret+0xd:
    call without frame pointer save/setup

With this patch, the warning is correctly suppressed, and the
kernel still passes the normal Google kernel developer tests.

Signed-off-by: John Sperbeck <jsperbeck@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/objtool/check.c