]> git.ipfire.org Git - thirdparty/linux.git/commit
ata: libata-eh: Update DIPM comments to reflect reality
authorNiklas Cassel <cassel@kernel.org>
Thu, 15 May 2025 13:56:23 +0000 (15:56 +0200)
committerDamien Le Moal <dlemoal@kernel.org>
Tue, 20 May 2025 09:20:36 +0000 (18:20 +0900)
commit381d43b26282377a7e2f7ddfdd0147ad72353621
tree712a2a1baceb187431510caeaa03a9407aed1604
parent3b0bca979344b2e26de8f4c175bed975b1d54e8f
ata: libata-eh: Update DIPM comments to reflect reality

The comments describing which LPM policies that has DIPM enabled predates
the introduction of the LPM policies ATA_LPM_MIN_POWER_WITH_PARTIAL and
ATA_LPM_MED_POWER_WITH_DIPM. Update the DIPM comments to reflect reality.

Also remove the sentence that claims that "Order device and link
configurations such that the host always allows DIPM requests."

This comment is written before 24e0e61db3cb ("ata: libata: disallow
dev-initiated LPM transitions to unsupported states").

Even though the set_lpm() call is done before enabling DIPM, the host will
not always allow DIPM requests. For all LPM polcies where DIPM is enabled,
only DIPM requests to LPM states that are supported by the HBA will be
allowed.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
drivers/ata/libata-eh.c