]> git.ipfire.org Git - thirdparty/samba.git/commit
silence "Can not convert group sid" warnings in the log
authorMichael Tokarev <mjt@tls.msk.ru>
Wed, 14 Feb 2024 12:26:29 +0000 (15:26 +0300)
committerPavel Filipensky <pfilipensky@samba.org>
Thu, 2 Jan 2025 17:01:30 +0000 (17:01 +0000)
commit3831a7e2fd41c3cba6d9c13f91582e8d8a3115c2
tree82807ed5833e3dfc3632346033855c816f91141b
parent05bf702f4a9ce3c62c1fbbbb762bafa93d7dc6ea
silence "Can not convert group sid" warnings in the log

/var/log/samba/log.winbind is full of messages like:

[2024/02/09 06:25:04.788182,  1, pid=74620] source3/winbindd/winbindd_getgroups.c:259(winbindd_getgroups_recv)
  Could not convert sid S-0-0: NT_STATUS_NONE_MAPPED

On a busy server these are logged several 1000s times per minute,
making any other messages basically invisible.

This is a work-around, a proper solution is to handle some
special SIDs (like this one) separately.  Once this is done,
this change can be reverted.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
source3/winbindd/winbindd_getgroups.c