]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
block, bfq: choose the last bfqq from merge chain in bfq_setup_cooperator()
authorYu Kuai <yukuai3@huawei.com>
Mon, 2 Sep 2024 13:03:27 +0000 (21:03 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 13:10:47 +0000 (15:10 +0200)
commit3883a6873b92c7e0dbe2e8b121107c1b4bfaeb64
tree35e2ed8d442761ba0ac03dc718d84cfcb5ef6765
parent8aa9de02a4be2e7006e636816ce19b0d667ceaa3
block, bfq: choose the last bfqq from merge chain in bfq_setup_cooperator()

[ Upstream commit 0e456dba86c7f9a19792204a044835f1ca2c8dbb ]

Consider the following merge chain:

Process 1       Process 2       Process 3 Process 4
 (BIC1)          (BIC2)          (BIC3)  (BIC4)
  Λ                |               |               |
   \--------------\ \-------------\ \-------------\|
                   V               V    V
  bfqq1--------->bfqq2---------->bfqq3----------->bfqq4

IO from Process 1 will get bfqf2 from BIC1 first, then
bfq_setup_cooperator() will found bfqq2 already merged to bfqq3 and then
handle this IO from bfqq3. However, the merge chain can be much deeper
and bfqq3 can be merged to other bfqq as well.

Fix this problem by iterating to the last bfqq in
bfq_setup_cooperator().

Fixes: 36eca8948323 ("block, bfq: add Early Queue Merge (EQM)")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20240902130329.3787024-3-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
block/bfq-iosched.c