]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
add slotscheck to CI
authorArie Bovenberg <a.c.bovenberg@gmail.com>
Sun, 6 Feb 2022 21:37:02 +0000 (16:37 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Mon, 7 Feb 2022 18:51:11 +0000 (13:51 -0500)
commit38cdd3946c337f3d917218cd1c8da67a971646ee
treeb84f1588556cfd62b67d629dc8db6d61c6f4870b
parent0566df2f79c7aae978bc0ef8e253cfcc4de54ecc
add slotscheck to CI

As discussed in #7589, `slotscheck` can prevent slots-related mistakes from creeping back in.

Plan for now is to have slotscheck part of the "lint" tests
(renamed from pep8) that will run for CI and github actions.

To support slotscheck's runtime nature, slotscheck is
run twice, first with cython exts enabled and then
with them disabled via new environment variable.
Also added sqlalchemy[mypy] dependency to support slots
checking the mypy plugin.

Found and fixed one more `__slots__` issue by disabling C
exts.

Closes: #7670
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/7670
Pull-request-sha: 3e77fe5449615a3c7c61ce9a1e4e79cd6636a89a

Change-Id: I90cdd284cdcee316a38856ba94d72ffc98947c5a
.github/workflows/run-on-pr.yaml
.github/workflows/run-test.yaml
lib/sqlalchemy/util/_has_cy.py
lib/sqlalchemy/util/_py_collections.py
pyproject.toml
tox.ini