]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
proc: fix -ESRCH error when writing to /proc/$pid/coredump_filter
authorColin Ian King <colin.king@canonical.com>
Fri, 18 Dec 2015 22:22:01 +0000 (14:22 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Feb 2016 22:28:23 +0000 (14:28 -0800)
commit38ff7eb030aaf1dc65a4c00fb322a36fbd6bdbdc
tree465b3ed8fd72468551073f35e6ea1f9413e99679
parentbffecd3844604aa095ed473d75f26028de5202f5
proc: fix -ESRCH error when writing to /proc/$pid/coredump_filter

commit 41a0c249cb8706a2efa1ab3d59466b23a27d0c8b upstream.

Writing to /proc/$pid/coredump_filter always returns -ESRCH because commit
774636e19ed51 ("proc: convert to kstrto*()/kstrto*_from_user()") removed
the setting of ret after the get_proc_task call and incorrectly left it as
-ESRCH.  Instead, return 0 when successful.

Example breakage:

  echo 0 > /proc/self/coredump_filter
  bash: echo: write error: No such process

Fixes: 774636e19ed51 ("proc: convert to kstrto*()/kstrto*_from_user()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/proc/base.c