]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output
authorJoe Perches <joe@perches.com>
Wed, 16 Sep 2020 20:40:38 +0000 (13:40 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 7 Mar 2021 10:27:45 +0000 (11:27 +0100)
commit390881843b4f13bcac8d58dcf1ebcc34e0deffea
treede7447b67200e144c2aa30740c7dd0c588b953b5
parent6c6711c1a0cd2675f9c537c96bd70ecdd84c5d3e
sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output

commit 2efc459d06f1630001e3984854848a5647086232 upstream.

Output defects can exist in sysfs content using sprintf and snprintf.

sprintf does not know the PAGE_SIZE maximum of the temporary buffer
used for outputting sysfs content and it's possible to overrun the
PAGE_SIZE buffer length.

Add a generic sysfs_emit function that knows that the size of the
temporary buffer and ensures that no overrun is done.

Add a generic sysfs_emit_at function that can be used in multiple
call situations that also ensures that no overrun is done.

Validate the output buffer argument to be page aligned.
Validate the offset len argument to be within the PAGE_SIZE buf.

Signed-off-by: Joe Perches <joe@perches.com>
Link: https://lore.kernel.org/r/884235202216d464d61ee975f7465332c86f76b2.1600285923.git.joe@perches.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Documentation/filesystems/sysfs.txt
fs/sysfs/file.c
include/linux/sysfs.h