]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
md/raid10: fix writes_pending and barrier reference leaks on discard failures
authorAbd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
Sat, 13 Jun 2026 18:28:09 +0000 (18:28 +0000)
committerYu Kuai <yukuai@fygo.io>
Sat, 20 Jun 2026 18:14:44 +0000 (02:14 +0800)
commit393d687131d8aa8c7e4de2cb494438e145d20fc2
treeae140e689a46c0ee6cf00ef84ce26f5c43a26d28
parente045d6ed33f8faa3e3dd6dc33c62ec01e3ad275d
md/raid10: fix writes_pending and barrier reference leaks on discard failures

raid10_make_request() acquires a writes_pending reference with
md_write_start() before calling raid10_handle_discard(). Several failure
paths in raid10_handle_discard() complete the bio and return without
releasing the corresponding reference, causing md_write_end() to be
skipped.

Call md_write_end() before returning from these failure paths to keep
writes_pending accounting balanced.

Additionally, discard split allocation failures can occur after
wait_barrier() succeeds. Those paths return without calling
allow_barrier(), leaking the associated barrier reference.

Release the barrier before returning from those paths.

Fixes: c9aa889b035f ("md: raid10 add nowait support")
Fixes: 4cf58d952909 ("md/raid10: Handle bio_split() errors")
Signed-off-by: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
Link: https://patch.msgid.link/20260613182810.1317258-4-abd.masalkhi@gmail.com
Signed-off-by: Yu Kuai <yukuai@fygo.io>
drivers/md/raid10.c