]> git.ipfire.org Git - thirdparty/linux.git/commit
platform/x86: dell-dw5826e: fix ACPI _DSM function index and bitmask usage
authorSurendra Singh Chouhan <kr494167@gmail.com>
Fri, 24 Jul 2026 12:55:33 +0000 (18:25 +0530)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 24 Jul 2026 16:21:39 +0000 (19:21 +0300)
commit39490ec6063d9dc3d995b7b48fc5106cd361a547
treef2325ea13cea9a0cb1fc9d0566bca16646145e9c
parent78bf392ba77dd8b2a25656e489449d2f91cfd1eb
platform/x86: dell-dw5826e: fix ACPI _DSM function index and bitmask usage

PALC_DSM_FN_TRIGGER_PLDR was defined as BIT(1) (value 2).

acpi_evaluate_dsm() expects a 0-based function index integer (0, 1,
2, ...), whereas acpi_check_dsm() expects a bitmask of supported
function indices (BIT(1), BIT(2), ...).

Because PALC_DSM_FN_TRIGGER_PLDR was defined as BIT(1),
acpi_evaluate_dsm() was evaluating Function Index 2 instead of Function
Index 1, while acpi_check_dsm() was checking for Function Index 1
support.

Fix this by setting PALC_DSM_FN_TRIGGER_PLDR to 1 (the function index)
and passing BIT(PALC_DSM_FN_TRIGGER_PLDR) to acpi_check_dsm().

Fixes: 1ab843135a77 ("platform/x86: dell-dw5826e: Add reset driver for DW5826e")
Signed-off-by: Surendra Singh Chouhan <kr494167@gmail.com>
Link: https://patch.msgid.link/20260724125533.74751-1-kr494167@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/dell/dell-dw5826e-reset.c