]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rpcrdma: fix handling for RDMA_CM_EVENT_DEVICE_REMOVAL
authorDan Aloni <dan.aloni@vastdata.com>
Mon, 6 May 2024 09:37:59 +0000 (12:37 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:39:47 +0000 (13:39 +0200)
commit39818fbd3e3a8ad0d065829007737f463ad7b256
tree00ef7199ee47d15ff784129fffc92a641b1578e4
parente5c34f10534d541545b852ef481a310b1f8deb2e
rpcrdma: fix handling for RDMA_CM_EVENT_DEVICE_REMOVAL

[ Upstream commit 4836da219781ec510c4c0303df901aa643507a7a ]

Under the scenario of IB device bonding, when bringing down one of the
ports, or all ports, we saw xprtrdma entering a non-recoverable state
where it is not even possible to complete the disconnect and shut it
down the mount, requiring a reboot. Following debug, we saw that
transport connect never ended after receiving the
RDMA_CM_EVENT_DEVICE_REMOVAL callback.

The DEVICE_REMOVAL callback is irrespective of whether the CM_ID is
connected, and ESTABLISHED may not have happened. So need to work with
each of these states accordingly.

Fixes: 2acc5cae2923 ('xprtrdma: Prevent dereferencing r_xprt->rx_ep after it is freed')
Cc: Sagi Grimberg <sagi.grimberg@vastdata.com>
Signed-off-by: Dan Aloni <dan.aloni@vastdata.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sunrpc/xprtrdma/verbs.c