]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfsd: fix auth_domain reference leak on nlm operations
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 25 Mar 2011 02:51:14 +0000 (22:51 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 14 Apr 2011 20:02:40 +0000 (13:02 -0700)
commit39932bd2baf36a8521b89795ac21efbec7e0d976
tree1860906c3d78d6fd6ae577aade1fe9298fb094a9
parent6fc45e2d18e042ac3d7677fcec64e2f0308f8b5f
nfsd: fix auth_domain reference leak on nlm operations

commit 954032d2527f2fce7355ba70709b5e143d6b686f upstream.

This was noticed by users who performed more than 2^32 lock operations
and hence made this counter overflow (eventually leading to
use-after-free's).  Setting rq_client to NULL here means that it won't
later get auth_domain_put() when it should be.

Appears to have been introduced in 2.5.42 by "[PATCH] kNFSd: Move auth
domain lookup into svcauth" which moved most of the rq_client handling
to common svcauth code, but left behind this one line.

Cc: Neil Brown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/nfsd/lockd.c