]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: cdns3: gadget: toggle cycle bit before reset endpoint
authorPeter Chen <peter.chen@nxp.com>
Wed, 19 Feb 2020 14:14:55 +0000 (22:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Mar 2020 06:18:31 +0000 (07:18 +0100)
commit39c49713ac17ec386d63a7b3ddc28052bd7871c3
treecb9fd120b523132f6c091208accffbe7af011aad
parent5cc981b986a61da0f38ec0c522771a80c889d598
usb: cdns3: gadget: toggle cycle bit before reset endpoint

commit 4bf2dd65135a2d7fe202f7c10d65b51bcf645ac6 upstream.

If there are TRBs pending during reset endpoint operation, the
DMA will advance after reset operation, but it isn't expected,
since the data is not yet available (For OUT, the data is not
yet available). After the data is ready, there won't be any
interrupt since the EP_TRADDR already points to next TRB entry
and doorbell is not set.

To fix it, it toggles cycle bit before reset operation, and restores
it after reset, it could avoid unexpected DMA advance due to
cycle bit is for software during the endpoint reset operation.

Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200219141455.23257-3-peter.chen@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/gadget.c