]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: af_alg - Fix incorrect boolean values in af_alg_ctx
authorEric Biggers <ebiggers@kernel.org>
Wed, 24 Sep 2025 20:18:22 +0000 (13:18 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Oct 2025 11:35:46 +0000 (13:35 +0200)
commit3a21698ace915a445bce2d0dcfc84b6d2199baf7
treee752ef2e9e24d4e0482aff028bd1449066e9eb6e
parent4bbfd1b290857b9d14ea9d91562bde55ff2bc85e
crypto: af_alg - Fix incorrect boolean values in af_alg_ctx

[ Upstream commit d0ca0df179c4b21e2a6c4a4fb637aa8fa14575cb ]

Commit 1b34cbbf4f01 ("crypto: af_alg - Disallow concurrent writes in
af_alg_sendmsg") changed some fields from bool to 1-bit bitfields of
type u32.

However, some assignments to these fields, specifically 'more' and
'merge', assign values greater than 1.  These relied on C's implicit
conversion to bool, such that zero becomes false and nonzero becomes
true.

With a 1-bit bitfields of type u32 instead, mod 2 of the value is taken
instead, resulting in 0 being assigned in some cases when 1 was intended.

Fix this by restoring the bool type.

Fixes: 1b34cbbf4f01 ("crypto: af_alg - Disallow concurrent writes in af_alg_sendmsg")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/crypto/if_alg.h