]> git.ipfire.org Git - thirdparty/libvirt.git/commit
remote_driver: Restore special behavior of remoteDomainGetBlockIoTune()
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 29 Jan 2024 09:07:05 +0000 (10:07 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 29 Jan 2024 11:50:26 +0000 (12:50 +0100)
commit3a3f73ea9f1925ca5e256fa54c5aa451ddeaa19e
treec565b55ba98613b2e717c63b9b48b71ab28429a9
parent7d9fe3a637795ef23d6c7152b57cd64f9f2894c7
remote_driver: Restore special behavior of remoteDomainGetBlockIoTune()

In v9.10.0-rc1~103 the remote driver was switched to g_auto() for
client RPC return parameters. But whilst doing so a small bug
slipped in: previously, when virDomainGetBlockIoTune() was called
with *nparams == 0, the function set *nparams to the number of
supported params and zero was returned (so that client can
allocate memory and call the API second time). IOW - the usual,
old style of APIs where we didn't want to allocate memory on
caller's behalf. But because of this bug, a negative one is
returned instead.

Fixes: 501825011c1fe80f458820c7efe5a198e0af9be5
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/remote/remote_driver.c