]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pps: add an error check in parport_attach
authorMa Ke <make24@iscas.ac.cn>
Wed, 28 Aug 2024 13:18:14 +0000 (21:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 13:11:17 +0000 (15:11 +0200)
commit3a69dcccd0ca39fea99026238daab40973bc62fe
tree74782b1673d354e8caed9b22ebaded4d58788530
parentec22387afb26dc0115f2e6a423b92edd38ecb03a
pps: add an error check in parport_attach

[ Upstream commit 62c5a01a5711c8e4be8ae7b6f0db663094615d48 ]

In parport_attach, the return value of ida_alloc is unchecked, witch leads
to the use of an invalid index value.

To address this issue, index should be checked. When the index value is
abnormal, the device should be freed.

Found by code review, compile tested only.

Cc: stable@vger.kernel.org
Fixes: fb56d97df70e ("pps: client: use new parport device model")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
Link: https://lore.kernel.org/r/20240828131814.3034338-1-make24@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pps/clients/pps_parport.c