]> git.ipfire.org Git - thirdparty/asterisk.git/commit
chan_iax2: Fix incorrect usage of ast_get_ip involving uninitialized struct
authorMatthew Jordan <mjordan@digium.com>
Tue, 5 Nov 2013 21:10:20 +0000 (21:10 +0000)
committerMatthew Jordan <mjordan@digium.com>
Tue, 5 Nov 2013 21:10:20 +0000 (21:10 +0000)
commit3a6b76c69e919e5602f07d1d800532a353b671e8
tree36d37e8e99ae8dc4491b4a4f5e2c2ac010e0639b
parent135ac61bc5c75be76fe5556338a45903abdab165
chan_iax2: Fix incorrect usage of ast_get_ip involving uninitialized struct

This started off as a fix for the failing IAX2 acl_call test in the Asterisk
Test Suite. When inspecting why that test was failing, it became clear that all
attempts to bind to any local loopback address was failing:

[Nov  2 15:56:28] VERBOSE[15787] chan_iax2.c:   == Binding IAX2 to address
                                 127.0.0.1:4569
[Nov  2 15:56:28] DEBUG[15787] netsock2.c: Splitting '127.0.0.1' into...
[Nov  2 15:56:28] DEBUG[15787] netsock2.c: ...host '127.0.0.1' and port ''.
[Nov  2 15:56:28] ERROR[15787] netsock2.c: getaddrinfo("127.0.0.1", "(null)",
                               ...): ai_family not supported
[Nov  2 15:56:28] WARNING[15787] acl.c: Unable to lookup '127.0.0.1'

While there's conceivably other ways for getaddrino to return EAI_FAMILY, the
most common way is if AF_INET, AF_INET6, or AF_UNSPEC is not provided as the
desired family. The culprit was the call to ast_get_ip, defined in acl.h. This
function uses the family from the passed in addr object (which it will also
populate when it returns!) when it eventually calls getaddrinfo.

This patch fixes the use of ast_get_ip that were not specifying the family in
chan_iax2. This prevents uninitialized use of the structure, so that the
addresses resolve correctly.

Review: https://reviewboard.asterisk.org/r/2991

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/12@402505 65c4cc65-6c06-0410-ace0-fbb531ad65f3
channels/chan_iax2.c