]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Consistently test for in-use shared memory.
authorNoah Misch <noah@leadboat.com>
Thu, 4 Apr 2019 00:03:46 +0000 (17:03 -0700)
committerNoah Misch <noah@leadboat.com>
Thu, 4 Apr 2019 00:03:50 +0000 (17:03 -0700)
commit3a70b66e625707bf3f8856be2a3d0ea74d6170d7
treeb45c99875b67207d5f31d78d0c46584953dfe792
parentf3461cb8f5b505878f33d6ded15eab6f0e1993dd
Consistently test for in-use shared memory.

postmaster startup scrutinizes any shared memory segment recorded in
postmaster.pid, exiting if that segment matches the current data
directory and has an attached process.  When the postmaster.pid file was
missing, a starting postmaster used weaker checks.  Change to use the
same checks in both scenarios.  This increases the chance of a startup
failure, in lieu of data corruption, if the DBA does "kill -9 `head -n1
postmaster.pid` && rm postmaster.pid && pg_ctl -w start".  A postmaster
will no longer recycle segments pertaining to other data directories.
That's good for production, but it's bad for integration tests that
crash a postmaster and immediately delete its data directory.  Such a
test now leaks a segment indefinitely.  No "make check-world" test does
that.  win32_shmem.c already avoided all these problems.  In 9.6 and
later, enhance PostgresNode to facilitate testing.  Back-patch to 9.4
(all supported versions).

Reviewed by Daniel Gustafsson and Kyotaro HORIGUCHI.

Discussion: https://postgr.es/m/20130911033341.GD225735@tornado.leadboat.com
src/backend/port/sysv_shmem.c
src/backend/port/win32_shmem.c
src/backend/postmaster/postmaster.c
src/backend/storage/ipc/ipci.c
src/backend/utils/init/postinit.c
src/include/storage/ipc.h
src/include/storage/pg_shmem.h