]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
soc: qcom: wcnss_ctrl: Fix increment in NV upload
authorBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 28 Feb 2018 00:45:25 +0000 (16:45 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 May 2018 05:50:47 +0000 (07:50 +0200)
commit3aa06676c1122efafd0d986f9a928d6f5df7ac38
treef8431df0230e786f4de8ecb62381d4caff5228d4
parentde4699cd616fee88b811b74b0b752388c093d3d5
soc: qcom: wcnss_ctrl: Fix increment in NV upload

[ Upstream commit 90c29ed7627b6b4aeb603ee197650173c8434512 ]

hdr.len includes both the size of the header and the fragment, so using
this when stepping through the firmware causes us to skip 16 bytes every
chunk of 3072 bytes; causing only the first fragment to actually be
valid data.

Instead use fragment size steps through the firmware blob.

Fixes: ea7a1f275cf0 ("soc: qcom: Introduce WCNSS_CTRL SMD client")
Reported-by: Will Newton <will.newton@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/soc/qcom/wcnss_ctrl.c