]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/amd/display: remove dpp pipes on failure to update pipe params
authorWenjing Liu <wenjing.liu@amd.com>
Wed, 29 May 2024 18:17:34 +0000 (14:17 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:15 +0000 (15:34 +0200)
commit3ab61af2901c7835c5650db292c7fc50ca93fe56
tree4c1dbd88f1cbad438b88770b343739f63325fea1
parent39b217193729aa45eded8de24d9245468a0c0263
drm/amd/display: remove dpp pipes on failure to update pipe params

[ Upstream commit 3ddd9c83ff7ac0ead38188425b14d03dc2f2c133 ]

[why]
There are cases where update pipe params could fail but dpp pipes are already
added to the state. In this case, we should remove dpp pipes so dc state is
restored back. If it is not restored, dc state is corrupted after calling this
function, so if we call the same interface with the corrupted state again, we
may end up programming pipe topology based on a corrupted dc state.

Reviewed-by: Dillon Varone <dillon.varone@amd.com>
Acked-by: Zaeem Mohamed <zaeem.mohamed@amd.com>
Signed-off-by: Wenjing Liu <wenjing.liu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/display/dc/core/dc_resource.c