]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
regmap: maple: Fix cache corruption in regcache_maple_drop()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Wed, 27 Mar 2024 11:44:06 +0000 (11:44 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:35:58 +0000 (16:35 +0200)
commit3af6c5ac72dc5b721058132a0a1d7779e443175e
tree9210ff0ead4ee3da53aeb4ee70efa7380d082f48
parent4e73748d5954a56420e549a87e3f78df62efd6f7
regmap: maple: Fix cache corruption in regcache_maple_drop()

[ Upstream commit 00bb549d7d63a21532e76e4a334d7807a54d9f31 ]

When keeping the upper end of a cache block entry, the entry[] array
must be indexed by the offset from the base register of the block,
i.e. max - mas.index.

The code was indexing entry[] by only the register address, leading
to an out-of-bounds access that copied some part of the kernel
memory over the cache contents.

This bug was not detected by the regmap KUnit test because it only
tests with a block of registers starting at 0, so mas.index == 0.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: f033c26de5a5 ("regmap: Add maple tree based register cache")
Link: https://msgid.link/r/20240327114406.976986-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/base/regmap/regcache-maple.c