]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: hub: take hub->hdev reference when processing from eventlist
authorJoe Lawrence <joe.lawrence@stratus.com>
Wed, 10 Sep 2014 19:07:50 +0000 (15:07 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 5 Oct 2014 20:40:58 +0000 (13:40 -0700)
commit3b16693f0d231d86acdb34ddf29103a282b8374e
tree31da9856dc37901d9aeddb681a8e515c6460606f
parentc14555bfc11e9455272e9c2459197559ea2ad957
usb: hub: take hub->hdev reference when processing from eventlist

commit c605f3cdff53a743f6d875b76956b239deca1272 upstream.

During surprise device hotplug removal tests, it was observed that
hub_events may try to call usb_lock_device on a device that has already
been freed. Protect the usb_device by taking out a reference (under the
hub_event_lock) when hub_events pulls it off the list, returning the
reference after hub_events is finished using it.

Signed-off-by: Joe Lawrence <joe.lawrence@stratus.com>
Suggested-by: David Bulkow <david.bulkow@stratus.com> for using kref
Suggested-by: Alan Stern <stern@rowland.harvard.edu> for placement
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hub.c