]> git.ipfire.org Git - thirdparty/suricata.git/commit
detect: fix multi inspect buffer issue; clean up
authorVictor Julien <victor@inliniac.net>
Thu, 13 May 2021 05:50:12 +0000 (07:50 +0200)
committerVictor Julien <victor@inliniac.net>
Thu, 24 Jun 2021 11:34:10 +0000 (13:34 +0200)
commit3b1a29e4ba2793e39d72c7dac03e8d82ee6e0138
tree5abf43230f663dc3c6243556910abd2e9e36bd48
parentfdc93130aaf9f4b97ad4ffa305f20d7b0b8be589
detect: fix multi inspect buffer issue; clean up

Fix multi inspect buffer API causing cleanup logic in the single
inspect buffer paths. This could lead to a buffer overrun in the
"to clear" logic.

Multi buffers now use InspectionBufferSetupMulti instead of
InspectionBuffer. This is enforced by a check in debug validation.

Simplify the multi inspect buffer setup code and update the callers.

(cherry picked from commit 3dc50322db0efb92683b9578c7dccd1fae4b5cb2)
59 files changed:
src/detect-dce-stub-data.c
src/detect-dnp3.c
src/detect-dns-query.c
src/detect-engine.c
src/detect-engine.h
src/detect-file-data.c
src/detect-filemagic.c
src/detect-filename.c
src/detect-http-client-body.c
src/detect-http-cookie.c
src/detect-http-header-names.c
src/detect-http-header.c
src/detect-http-headers-stub.h
src/detect-http-host.c
src/detect-http-method.c
src/detect-http-protocol.c
src/detect-http-raw-header.c
src/detect-http-request-line.c
src/detect-http-response-line.c
src/detect-http-start.c
src/detect-http-stat-code.c
src/detect-http-stat-msg.c
src/detect-http-ua.c
src/detect-http-uri.c
src/detect-ipv4hdr.c
src/detect-ipv6hdr.c
src/detect-krb5-cname.c
src/detect-krb5-sname.c
src/detect-sip-method.c
src/detect-sip-protocol.c
src/detect-sip-request-line.c
src/detect-sip-response-line.c
src/detect-sip-stat-code.c
src/detect-sip-stat-msg.c
src/detect-sip-uri.c
src/detect-smb-share.c
src/detect-snmp-community.c
src/detect-ssh-proto.c
src/detect-ssh-software.c
src/detect-tcphdr.c
src/detect-template-buffer.c
src/detect-tls-cert-fingerprint.c
src/detect-tls-cert-issuer.c
src/detect-tls-cert-serial.c
src/detect-tls-cert-subject.c
src/detect-tls-certs.c
src/detect-tls-ja3-hash.c
src/detect-tls-ja3-string.c
src/detect-tls-ja3s-hash.c
src/detect-tls-ja3s-string.c
src/detect-tls-sni.c
src/detect-transform-compress-whitespace.c
src/detect-transform-dotprefix.c
src/detect-transform-md5.c
src/detect-transform-sha1.c
src/detect-transform-sha256.c
src/detect-transform-strip-whitespace.c
src/detect-udphdr.c
src/detect.h