]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dp83640: don't recieve time stamps twice
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 18 Apr 2017 19:14:26 +0000 (22:14 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 May 2017 15:37:40 +0000 (08:37 -0700)
commit3b600a30d126809ccfb6a66bcecaae0ad0cdde6a
tree062a32b70f9f43b1d2779538c2b12cc1d629f0d0
parenta024074740e75310e7c884bed6f1f6b354936727
dp83640: don't recieve time stamps twice

[ Upstream commit 9d386cd9a755c8293e8916264d4d053878a7c9c7 ]

This patch is prompted by a static checker warning about a potential
use after free.  The concern is that netif_rx_ni() can free "skb" and we
call it twice.

When I look at the commit that added this, it looks like some stray
lines were added accidentally.  It doesn't make sense to me that we
would recieve the same data two times.  I asked the author but never
recieved a response.

I can't test this code, but I'm pretty sure my patch is correct.

Fixes: 4b063258ab93 ("dp83640: Delay scheduled work.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/phy/dp83640.c