]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
tracing: branch: Fix inverted check on stat tracer registration
authorBreno Leitao <leitao@debian.org>
Mon, 20 Apr 2026 13:25:09 +0000 (06:25 -0700)
committerSteven Rostedt <rostedt@goodmis.org>
Tue, 28 Apr 2026 18:28:29 +0000 (14:28 -0400)
commit3b75dd76e64a04771861bb5647951c264919e563
tree27e8045c5332240d71c921fcd22a44998b93df78
parent254f49634ee16a731174d2ae34bc50bd5f45e731
tracing: branch: Fix inverted check on stat tracer registration

init_annotated_branch_stats() and all_annotated_branch_stats() check the
return value of register_stat_tracer() with "if (!ret)", but
register_stat_tracer() returns 0 on success and a negative errno on
failure. The inverted check causes the warning to be printed on every
successful registration, e.g.:

  Warning: could not register annotated branches stats

while leaving real failures silent. The initcall also returned a
hard-coded 1 instead of the actual error.

Invert the check and propagate ret so that the warning fires on real
errors and the initcall reports the correct status.

Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: https://patch.msgid.link/20260420-tracing-v1-1-d8f4cd0d6af1@debian.org
Fixes: 002bb86d8d42 ("tracing/ftrace: separate events tracing and stats tracing engine")
Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_branch.c