]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN
authorAbhinav Kumar <quic_abhinavk@quicinc.com>
Thu, 1 Feb 2024 00:47:36 +0000 (16:47 -0800)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:47 +0000 (18:19 -0400)
commit3bb4f4b162760536287eee298810bb5b89512f36
tree7372ccf3bc30bf54aa9626f3c19c2507c70d495c
parente2326c8ae3a61af3d5cb841e761b0791923d968c
drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

[ Upstream commit 2f4a67a3894e15c135125cb54edc5b43abc1b70e ]

Currently INTF_CFG2_DATA_HCTL_EN is coupled with the enablement
of widebus but this is incorrect because we should be enabling
this bit independent of widebus except for cases where compression
is enabled in one pixel per clock mode.

Fix this by making the condition checks more explicit and enabling
INTF_CFG2_DATA_HCTL_EN for all other cases when supported by DPU.

Fixes: 3309a7563971 ("drm/msm/dpu: revise timing engine programming to support widebus feature")
Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/576722/
Link: https://lore.kernel.org/r/20240201004737.2478-1-quic_abhinavk@quicinc.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h