]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: uvcvideo: Fix crash during unbind if gpio unit is in use
authorRicardo Ribalda <ribalda@chromium.org>
Wed, 6 Nov 2024 20:36:07 +0000 (20:36 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Mar 2025 15:56:32 +0000 (16:56 +0100)
commit3c00e94d00ca079bef7906d6f39d1091bccfedd3
tree00422989a3f0230ba0349c10d70604799439ab1d
parentce8d2e914b0c82801fc35ae321c2cddcc605f05f
media: uvcvideo: Fix crash during unbind if gpio unit is in use

[ Upstream commit a9ea1a3d88b7947ce8cadb2afceee7a54872bbc5 ]

We used the wrong device for the device managed functions. We used the
usb device, when we should be using the interface device.

If we unbind the driver from the usb interface, the cleanup functions
are never called. In our case, the IRQ is never disabled.

If an IRQ is triggered, it will try to access memory sections that are
already free, causing an OOPS.

We cannot use the function devm_request_threaded_irq here. The devm_*
clean functions may be called after the main structure is released by
uvc_delete.

Luckily this bug has small impact, as it is only affected by devices
with gpio units and the user has to unbind the device, a disconnect will
not trigger this error.

Cc: stable@vger.kernel.org
Fixes: 2886477ff987 ("media: uvcvideo: Implement UVC_EXT_GPIO_UNIT")
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/20241106-uvc-crashrmmod-v6-1-fbf9781c6e83@chromium.org
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/uvc/uvc_driver.c
drivers/media/usb/uvc/uvcvideo.h