]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
don't base compilation off the int value of offset/limit part II
authorMike Bayer <mike_mp@zzzcomputing.com>
Wed, 14 Apr 2021 20:14:36 +0000 (16:14 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Wed, 14 Apr 2021 20:27:19 +0000 (16:27 -0400)
commit3c0a0a72015711989e06b16883a333a279bd095f
tree7f583146a1705c715e429cc7f31bc0b29b890d0f
parentcee6d12a69af38915316d6db8ca59c54325904ea
don't base compilation off the int value of offset/limit part II

Fixed an additional regression in the same area as that of :ticket:`6184`,
where using a value of 0 for OFFSET in conjunction with LIMIT with SQL
Server would create a statement using "TOP", as was the behavior in 1.3,
however due to caching would then fail to respond accordingly to other
values of OFFSET. If the "0" wasn't first, then it would be fine. For the
fix, the "TOP" syntax is now only emitted if the OFFSET value is omitted
entirely, that is, :meth:`_sql.Select.offset` is not used. Note that this
change now requires that if the "with_ties" or "percent" modifiers are
used, the statement can't specify an OFFSET of zero, it now needs to be
omitted entirely.

Fixes: #6265
Change-Id: If30596b8dcd9f2ce4221cd87c5407fa81f5f9a90
doc/build/changelog/unreleased_14/6265.rst [new file with mode: 0644]
lib/sqlalchemy/dialects/mssql/base.py
lib/sqlalchemy/testing/suite/test_select.py
test/dialect/mssql/test_compiler.py