]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: qcom: q6afe: Fix confusing cleanup.h syntax
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Sat, 29 Nov 2025 13:17:56 +0000 (14:17 +0100)
committerMark Brown <broonie@kernel.org>
Sun, 14 Dec 2025 10:33:14 +0000 (19:33 +0900)
commit3c84bfa47ff29ec0c202cb139d365421c6778d65
treef34c02983f8e0f41d781f1631c1d9a75f45ed1cd
parent310e6f95eedaae04990072078adbb38beb149811
ASoC: qcom: q6afe: Fix confusing cleanup.h syntax

Commit 55094e55ae36 ("ASoc: qcom: q6afe: Use automatic cleanup of
kfree()") did not make the code simpler but more complicated.  Already
simple code of allocation and free, without any error paths, got now
declaration with one constructor followed by another allocation, which
is in contrary to explicit coding rules guiding cleanup.h:

"Given that the "__free(...) = NULL" pattern for variables defined at
the top of the function poses this potential interdependency problem the
recommendation is to always define and assign variables in one statement
and not group variable definitions at the top of the function when
__free() is used."

Code does not have a bug, but is less readable and uses discouraged
coding practice, so fix that by moving declaration to the place of
assignment.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-4-c38b06884e39@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/qdsp6/q6afe.c