]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Propagate xactStartTimestamp and stmtStartTimestamp to parallel workers.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 6 Oct 2018 16:00:10 +0000 (12:00 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 6 Oct 2018 16:00:10 +0000 (12:00 -0400)
commit3c9dd963cec6d4c314bccf74256acc893108a4be
treec170e73d54ab7ebce8dceadb45626df0da21e125
parent0dc6bf633a2857294cd0d1b9a74c7f49836d5898
Propagate xactStartTimestamp and stmtStartTimestamp to parallel workers.

Previously, a worker process would establish values for these based on
its own start time.  In v10 and up, this can trivially be shown to cause
misbehavior of transaction_timestamp(), timestamp_in(), and related
functions which are (perhaps unwisely?) marked parallel-safe.  It seems
likely that other behaviors might diverge from what happens in the parent
as well.

It's not as trivial to demonstrate problems in 9.6 or 9.5, but I'm sure
it's still possible, so back-patch to all branches containing parallel
worker infrastructure.

In HEAD only, mark now() and statement_timestamp() as parallel-safe
(other affected functions already were).  While in theory we could
still squeeze that change into v11, it doesn't seem important enough
to force a last-minute catversion bump.

Konstantin Knizhnik, whacked around a bit by me

Discussion: https://postgr.es/m/6406dbd2-5d37-4cb6-6eb2-9c44172c7e7c@postgrespro.ru
src/backend/access/transam/parallel.c
src/backend/access/transam/xact.c
src/include/access/xact.h