]> git.ipfire.org Git - thirdparty/asterisk.git/commit
res_adsi: Fix major regression caused by media format rearchitecture.
authorNaveen Albert <asterisk@phreaknet.org>
Wed, 23 Nov 2022 22:59:16 +0000 (22:59 +0000)
committerGeorge Joseph <gjoseph@digium.com>
Thu, 8 Dec 2022 18:36:52 +0000 (12:36 -0600)
commit3d4162af44d80ac3536326d84e498e86c84f2048
tree7db41c9f917d1ff72692d5da2dcddb66c15ab0f0
parentf5a7efb963c09261dae1d188d680e055e00ad206
res_adsi: Fix major regression caused by media format rearchitecture.

The commit that rearchitected media formats,
a2c912e9972c91973ea66902d217746133f96026 (ASTERISK_23114)
introduced a regression by improperly translating code in res_adsi.c.
In particular, the pointer to the frame buffer was initialized
at the top of adsi_careful_send, rather than dynamically updating it
for each frame, as is required.

This resulted in the first frame being repeatedly sent,
rather than advancing through the frames.
This corrupted the transmission of the CAS to the CPE,
which meant that CPE would never respond with the DTMF acknowledgment,
effectively completely breaking ADSI functionality.

This issue is now fixed, and ADSI now works properly again.

ASTERISK-29793 #close

Change-Id: Icdeddf733eda2981c98712d1ac9cddc0db507dbe
res/res_adsi.c