]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mfd: rtsx_pcr: Fix MSI enable error handling
authorChris Ball <chris@printf.net>
Thu, 4 Sep 2014 16:11:53 +0000 (17:11 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 13 Nov 2014 18:02:18 +0000 (19:02 +0100)
commit3d96e8ff2dbd213598460bda628892ce091f8dcc
tree85a5e63ce7c25ae36c40f380b42e7bfd47c5fd92
parent365446fe1c7bf1b481cedfb9e50cfc8a86fdde89
mfd: rtsx_pcr: Fix MSI enable error handling

commit 5152970538a5e16c03bbcb9f1c780489a795ed40 upstream.

pci_enable_msi() can return failure with both positive and negative
integers -- it returns 0 for success -- but is only tested here for
"if (ret < 0)".  This causes us to try to use MSI on the RTS5249 SD
reader in the Dell XPS 11 when enabling MSI failed, causing:

[    1.737110] rtsx_pci: probe of 0000:05:00.0 failed with error -110

Reported-by: D. Jared Dominguez <Jared_Dominguez@Dell.com>
Tested-by: D. Jared Dominguez <Jared_Dominguez@Dell.com>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/mfd/rtsx_pcr.c