]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iwlwifi: mvm: fix endianity issues with Smart Fifo commands
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Thu, 31 Jul 2014 11:32:37 +0000 (14:32 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 5 Oct 2014 20:41:05 +0000 (13:41 -0700)
commit3dbf8d067ec53d0da2e139996daf2ae3d2dfe13e
tree802cf430b9356df82d48709048ab1627bb0e96ea
parent91ee0a8ed50938b5b7fb50a22183a698c929a7be
iwlwifi: mvm: fix endianity issues with Smart Fifo commands

commit 86974bff066dd8b98be46d7c7d3aba89034f0833 upstream.

This code was broken on big endian systems. Sparse didn't
catch the bug since the firmware command was not tagged as
little endian.
Fix the bug for big endian systems and tag the field in the
firmware command to prevent such issues in the future.

Fixes: 1f3b0ff8ec ("iwlwifi: mvm: Add Smart FIFO support")
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/iwlwifi/mvm/fw-api.h
drivers/net/wireless/iwlwifi/mvm/sf.c