]> git.ipfire.org Git - thirdparty/sqlalchemy/alembic.git/commit
Update the type comparison code used for schema autogeneration. Compare
authorPaul Becotte <pjbecotte@gmail.com>
Fri, 24 Jan 2020 00:36:33 +0000 (19:36 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 4 Feb 2020 19:01:25 +0000 (14:01 -0500)
commit3ddf82e1e2b4fff47edbd45dd493e6bbd5880496
tree71c3c66aedf3fd18c0005aaf8d60c089eab533c1
parente7d1124a2a21d6236db4f850fa2f9df346e2299e
Update the type comparison code used for schema autogeneration. Compare

A major rework of the "type comparison" logic is in place which changes the
entire approach by which column datatypes are compared.  Types are now
compared based on the DDL string generated by the metadata type vs. the
datatype reflected from the database.  This means we compare types based on
what would actually render and additionally if elements of the types change
like string length, those changes are detected as well.  False positives
like those generated between SQLAlchemy Boolean and MySQL TINYINT should
also be resolved.   Thanks very much to Paul Becotte  for lots of hard work
and patience on this one.

Fixes: #605
Closes: #619
Pull-request: https://github.com/sqlalchemy/alembic/pull/619
Pull-request-sha: 1a6a3860881081c3b98fdbfc203f8d3af5f98926

Change-Id: I1ab30f2a30fc567cde56b5b8be5f521ff235b67b
.gitignore
alembic/__init__.py
alembic/ddl/impl.py
alembic/ddl/mysql.py
alembic/ddl/oracle.py
alembic/ddl/postgresql.py
docs/build/autogenerate.rst
docs/build/unreleased/605.rst [new file with mode: 0644]
tests/requirements.py
tests/test_autogen_diffs.py