]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: dsa: hellcreek: fix missing error handling in LED registration
authorPavel Zhigulin <Pavel.Zhigulin@kaspersky.com>
Thu, 13 Nov 2025 13:57:44 +0000 (16:57 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Dec 2025 10:45:53 +0000 (11:45 +0100)
commit3e4306dc9e4741aa3ec6ea65e41eb47624bab06c
treeac1db45fdbd81e24cda0f9d157d1863cdecbd502
parent27ea5c2c75c3419a9a019240ca44b9256f628df1
net: dsa: hellcreek: fix missing error handling in LED registration

[ Upstream commit e6751b0b19a6baab219a62e1e302b8aa6b5a55b2 ]

The LED setup routine registered both led_sync_good
and led_is_gm devices without checking the return
values of led_classdev_register(). If either registration
failed, the function continued silently, leaving the
driver in a partially-initialized state and leaking
a registered LED classdev.

Add proper error handling

Fixes: 7d9ee2e8ff15 ("net: dsa: hellcreek: Add PTP status LEDs")
Signed-off-by: Pavel Zhigulin <Pavel.Zhigulin@kaspersky.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Kurt Kanzenbach <kurt@linutronix.de>
Link: https://patch.msgid.link/20251113135745.92375-1-Pavel.Zhigulin@kaspersky.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/dsa/hirschmann/hellcreek_ptp.c