]> git.ipfire.org Git - thirdparty/linux.git/commit
can: gs_usb: gs_can_open(): fix error handling
authorMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 1 Dec 2025 18:26:38 +0000 (19:26 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 10 Dec 2025 08:30:31 +0000 (09:30 +0100)
commit3e54d3b4a8437b6783d4145c86962a2aa51022f3
treea6628c20a94a154a63da4ad64b1c4103e29e7e0f
parent6abd4577bccc66f83edfdb24dc484723ae99cbe8
can: gs_usb: gs_can_open(): fix error handling

Commit 2603be9e8167 ("can: gs_usb: gs_can_open(): improve error handling")
added missing error handling to the gs_can_open() function.

The driver uses 2 USB anchors to track the allocated URBs: the TX URBs in
struct gs_can::tx_submitted for each netdev and the RX URBs in struct
gs_usb::rx_submitted for the USB device. gs_can_open() allocates the RX
URBs, while TX URBs are allocated during gs_can_start_xmit().

The cleanup in gs_can_open() kills all anchored dev->tx_submitted
URBs (which is not necessary since the netdev is not yet registered), but
misses the parent->rx_submitted URBs.

Fix the problem by killing the rx_submitted instead of the tx_submitted.

Fixes: 2603be9e8167 ("can: gs_usb: gs_can_open(): improve error handling")
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20251210-gs_usb-fix-error-handling-v1-1-d6a5a03f10bb@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/gs_usb.c