]> git.ipfire.org Git - thirdparty/git.git/commit
reftable/basics: fix return type of `binsearch()` to be `size_t`
authorPatrick Steinhardt <ps@pks.im>
Wed, 3 Apr 2024 06:03:56 +0000 (08:03 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 3 Apr 2024 16:16:49 +0000 (09:16 -0700)
commit3e7b36d129a5972e20cab4e55c43a8628b4d2c9c
tree045798d48a16043bb5f62ca9b7f801abcfb92cfa
parent11c821f2f2a31e70fb5cc449f9a29401c333aad2
reftable/basics: fix return type of `binsearch()` to be `size_t`

The `binsearch()` function can be used to find the first element for
which a callback functions returns a truish value. But while the array
size is of type `size_t`, the function in fact returns an `int` that is
supposed to index into that array.

Fix the function signature to return a `size_t`. This conversion does
not change any semantics given that the function would only ever return
a value in the range `[0, sz]` anyway.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
reftable/basics.c
reftable/basics.h
reftable/basics_test.c
reftable/block.c
reftable/refname.c