]> git.ipfire.org Git - thirdparty/samba.git/commit
ldb-samba: remove unused ldif_comparision_objectSid_isString()
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 17 Apr 2024 13:49:11 +0000 (01:49 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 7 May 2024 23:25:35 +0000 (23:25 +0000)
commit3e899ef5bfa67a12e8eb18cbebc06367f37a8376
treefb62986e89ebfe30595be3dd29fc80f43ffe9ca0
parent8c702735641aaad58c317843c547249c6bd1c716
ldb-samba: remove unused ldif_comparision_objectSid_isString()

This is unused because it does things badly, by just guessing and
not allowing valid sids that start with "s-". All the places that used
to use it were calling ldif_read_objectSid() or similar which correctly
check for string SIDs by actually trying to parse them. That begins
with looking for the "S-"/"s-", so this shortcut is not saving any real
work.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10763

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/ldb-samba/ldif_handlers.c